fix: Disable Zone Redundant for all locations #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirajC-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR disables public blob access and zone redundancy across storage, Cosmos DB, and container app environments to improve security and simplify configuration.
- Force
allowBlobPublicAccesstofalseon the storage account - Explicitly set
isZoneRedundant: falsefor Cosmos DB - Always use
zoneRedundant: falsefor container app environments
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/main.bicep | Disabled blob public access unconditionally |
| infra/main.bicep | Added explicit isZoneRedundant: false to Cosmos DB accounts |
| infra/main.bicep | Hardcoded zoneRedundant: false for container app environments |
Comments suppressed due to low confidence (3)
infra/main.bicep:1039
- [nitpick] Add a brief comment or update project documentation to explain why zone redundancy is being explicitly disabled for Cosmos DB accounts, so future maintainers understand the security or cost rationale.
isZoneRedundant: false
infra/main.bicep:864
- The
publicNetworkAccessproperty still allows network-level access whenvirtualNetworkEnabledis false, but blob-level access is always blocked. This mismatch can cause confusion or unintended failures; consider aligning both settings (e.g., disable public network access as well or make the blob access toggle follow the same condition).
allowBlobPublicAccess: false
infra/main.bicep:1077
- [nitpick] Since this setting no longer depends on
virtualNetworkEnabled, consider parameterizingzoneRedundantor removing the now-unusedvirtualNetworkEnabledtoggle to keep configuration flexible and avoid dead code.
zoneRedundant: false
Roopan-Microsoft
approved these changes
Jun 12, 2025
blessing-msft
pushed a commit
that referenced
this pull request
Aug 1, 2025
fix: Disable Zone Redundant for all locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the
infra/main.bicepfile to enhance security and simplify configurations. The changes primarily involve disabling public access and zone redundancy for various resources.Security Enhancements:
Updated
allowBlobPublicAccessto always befalse, regardless of thevirtualNetworkEnabledsetting, ensuring no public access to storage blobs.Configuration Simplifications:
Added
isZoneRedundant: falseto explicitly disable zone redundancy for Cosmos DB accounts.Updated
zoneRedundantto always befalse, simplifying the configuration for container app environments.## PurposeDoes this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information